HIVE-29178: Add Catalog properties support #6123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why that many thrift gen changes? |
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
@deniskuzZ Yes. Every modification to hive_metastore.thrift will result in changes to many gen files. For example, HIVE-28975. I believe this is the normal behavior of the Thrift tool. I am using Thrift version 0.16.0 locally and regenerated the code with the command: |
zhangbutao
force-pushed
the
HIVE-29178_CAT_PROPERTY
branch
from
db0093e to
8203c56
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
deniskuzZ
reviewed
Oct 17, 2025
deniskuzZ
reviewed
Oct 17, 2025
deniskuzZ
reviewed
Oct 17, 2025
parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2025
ql/src/java/org/apache/hadoop/hive/ql/ddl/catalog/create/CreateCatalogDesc.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2025
deniskuzZ
reviewed
Oct 17, 2025
standalone-metastore/metastore-server/src/main/resources/package.jdo
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2025
There was a problem hiding this comment.
thanks for the PR @zhangbutao! added just a few minor comments, otherwise LGTM
zhangbutao
force-pushed
the
HIVE-29178_CAT_PROPERTY
branch
from
8203c56 to
0fdb746
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
deniskuzZ
reviewed
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a properties attribute to the catalog, which allows the creation and modification of catalog properties. This PR can serve for the upcoming Federated Catalog, as we will use properties to define the catalog type and pass custom property for each catalog.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile='catalog.q' -Dtest.output.overwrite=true -pl itests/qtest -Pitests
And local Hive cluster test.